TropicalGeometry: tropical linear spaces from graphs #4445
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ollieclarke8787 Would you be able to review this pull request? |
YueRen
changed the title
YueRen
force-pushed
the
yr/TropicalLinearSpace
branch
from
274f8c2 to
b86b6a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4445 +/- ##
==========================================
- Coverage 84.55% 84.39% -0.16%
==========================================
Files 672 672
Lines 88880 89132 +252
==========================================
+ Hits 75152 75225 +73
- Misses 13728 13907 +179
|
lgoettgens
reviewed
Jan 10, 2025
ollieclarke8787
approved these changes
Jan 13, 2025
YueRen
force-pushed
the
yr/TropicalLinearSpace
branch
3 times, most recently
from
bcd1d94 to
69551de
Compare
YueRen
force-pushed
the
yr/TropicalLinearSpace
branch
from
69551de to
9079fd8
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
benlorenz
reviewed
Jan 30, 2025
| @@ -365,6 +365,30 @@ function tropical_linear_space(I::MPolyIdeal, nu::Union{Nothing,TropicalSemiring | |||
| end | |||
|
|
|||
|
|
|||
| @doc raw""" | |||
| tropical_linear_space(G::Graph, nu::TropicalSemiringMap; weighted_polyhedral_complex_only::Bool=false) | |||
There was a problem hiding this comment.
Suggested change
| tropical_linear_space(G::Graph, nu::TropicalSemiringMap; weighted_polyhedral_complex_only::Bool=false) | |
| tropical_linear_space(G::Graph[, nu::TropicalSemiringMap]; weighted_polyhedral_complex_only::Bool=false) |
Maybe mention that this is optional (and what it defaults to)?
Co-authored-by: Benjamin Lorenz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds a new constructor for tropical linear spaces from graphs. Useful (for me) for example for graph rigidity questions (see e.g. here).